• Amitoj Kaur Chawla's avatar
    dmascc: Return correct error codes · 37ace20a
    Amitoj Kaur Chawla authored
    This change has been made with the goal that kernel functions should
    return something more descriptive than -1 on failure.
    
    A variable `err` has been introduced for storing error codes.
    
    The return value of kzalloc on failure should return a -1 and not a
    -ENOMEM. This was found using Coccinelle. A simplified version of
    the semantic patch used is:
    
    //<smpl>
    @@
    expression *e;
    identifier l1;
    @@
    
    e = kzalloc(...);
    if (e == NULL) {
    ...
    goto l1;
    }
    l1:
    ...
    return -1
    + -ENOMEM
    ;
    //</smpl
    
    Furthermore, set `err` to -ENOMEM on failure of alloc_netdev(), and to
    -ENODEV on failure of register_netdev() and probe_irq_off().
    
    The single call site only checks that the return value is not 0,
    hence no change is required at the call site.
    Signed-off-by: default avatarAmitoj Kaur Chawla <amitoj1606@gmail.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    37ace20a
dmascc.c 37 KB