• Gerrit Renker's avatar
    dccp ccid-3: Simplify and consolidate tx_parse_options · 37efb03f
    Gerrit Renker authored
    This simplifies and consolidates the TX option-parsing code:
    
     1. The Loss Intervals option is not currently used, so dead code related to
        this option is removed. I am aware of no plans to support the option, but
        if someone wants to implement it (e.g. for inter-op tests), it is better
        to start afresh than having to also update currently unused code.
    
     2. The Loss Event and Receive Rate options have a lot of code in common (both
        are 32 bit, both have same length etc.), so this is consolidated.
    
     3. The test against GSR is not necessary, because
        - on first loading CCID3, ccid_new() zeroes out all fields in the socket;
        - ccid3_hc_tx_packet_recv() treats 0 and ~0U equivalently, due to
    
    	pinv = opt_recv->ccid3or_loss_event_rate;
    	if (pinv == ~0U || pinv == 0)
    		hctx->p = 0;
    
        - as a result, the sequence number field is removed from opt_recv.
    Signed-off-by: default avatarGerrit Renker <gerrit@erg.abdn.ac.uk>
    37efb03f
ccid3.h 5.61 KB