• Tomas Elf's avatar
    drm/i915: Early exit from semaphore_waits_for for execlist mode. · 381e8ae3
    Tomas Elf authored
    When submitting semaphores in execlist mode the hang checker crashes in this
    function because it is only runnable in ring submission mode. The reason this
    is of particular interest to the TDR patch series is because we use semaphores
    as a mean to induce hangs during testing (which is the recommended way to
    induce hangs for gen8+). It's not clear how this is supposed to work in
    execlist mode since:
    
    1. This function requires a ring buffer.
    
    2. Retrieving a ring buffer in execlist mode requires us to retrieve the
    corresponding context, which we get from a request.
    
    3. Retieving a request from the hang checker is not straight-forward since that
    requires us to grab the struct_mutex in order to synchronize against the
    request retirement thread.
    
    4. Grabbing the struct_mutex from the hang checker is nothing that we will do
    since that puts us at risk of deadlock since a hung thread might be holding the
    struct_mutex already.
    
    Therefore it's not obvious how we're supposed to deal with this. For now, we're
    doing an early exit from this function, which avoids any kernel panic situation
    when running our own internal TDR ULT.
    
    * v2: (Chris Wilson)
    Turned the execlist mode check into a ringbuffer NULL check to make it more
    submission mode agnostic and less of a layering violation.
    Signed-off-by: default avatarTomas Elf <tomas.elf@intel.com>
    Cc: Chris Wilson <chris@chris-wilson.co.uk>
    Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
    Signed-off-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
    381e8ae3
i915_irq.c 127 KB