• Alexander Wetzel's avatar
    mac80211: fix TX aggregation stop race · 39c1134c
    Alexander Wetzel authored
    The mac80211 tear down code is not waiting for the driver call back.
    This can bring down the the TX path (TID) till the user manually
    reconnects. (Observed with iwldvm and enabled TX aggregation.)
    
    The race can be prevented when the ampdu_mlme worker handles the tear
    down.
    
    The race:
     * ieee80211_sta_tear_down_BA_sessions calls
       ___ieee80211_stop_tx_ba_session for all TIDs,
    
     * then cancels the ampdu_mlme worker
    
     * and cleanups the TIDs the driver already has called back for.
    
     * ieee80211_stop_tx_ba_cb will never be called for a TID if the callback
       came after the the check in ieee80211_sta_tear_down_BA_sessions.
    Signed-off-by: default avatarAlexander Wetzel <Alexander.Wetzel@web.de>
    [johannes: "enabled" -> "blocked" and invert logic, simplify init]
    Signed-off-by: default avatarJohannes Berg <johannes.berg@intel.com>
    39c1134c
ht.c 17 KB