• Josh Poimboeuf's avatar
    x86/unwind: Dump all stacks in unwind_dump() · 262fa734
    Josh Poimboeuf authored
    Currently unwind_dump() dumps only the most recently accessed stack.
    But it has a few issues.
    
    In some cases, 'first_sp' can get out of sync with 'stack_info', causing
    unwind_dump() to start from the wrong address, flood the printk buffer,
    and eventually read a bad address.
    
    In other cases, dumping only the most recently accessed stack doesn't
    give enough data to diagnose the error.
    
    Fix both issues by dumping *all* stacks involved in the trace, not just
    the last one.
    Signed-off-by: default avatarJosh Poimboeuf <jpoimboe@redhat.com>
    Cc: Andy Lutomirski <luto@kernel.org>
    Cc: Borislav Petkov <bp@alien8.de>
    Cc: Brian Gerst <brgerst@gmail.com>
    Cc: Denys Vlasenko <dvlasenk@redhat.com>
    Cc: H. Peter Anvin <hpa@zytor.com>
    Cc: Linus Torvalds <torvalds@linux-foundation.org>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: Thomas Gleixner <tglx@linutronix.de>
    Fixes: 8b5e99f0 ("x86/unwind: Dump stack data on warnings")
    Link: http://lkml.kernel.org/r/016d6a9810d7d1bfc87ef8c0e6ee041c6744c909.1493171120.git.jpoimboe@redhat.comSigned-off-by: default avatarIngo Molnar <mingo@kernel.org>
    262fa734
unwind_frame.c 9.45 KB