• Aleksey Makarov's avatar
    net: thunderx: fix nicvf_set_rxfh() · 89987844
    Aleksey Makarov authored
    This fixes a copypaste bug that was discovered by a static analysis
    tool:
    
    The patch 4863dea3: "net: Adding support for Cavium ThunderX
    network controller" from May 26, 2015, leads to the following static
    checker warning:
    
            drivers/net/ethernet/cavium/thunder/nicvf_ethtool.c:517
    nicvf_set_rxfh()
            warn: we tested 'hkey' before and it was 'false'
    
    drivers/net/ethernet/cavium/thunder/nicvf_ethtool.c
       506          /* We do not allow change in unsupported parameters */
       507          if (hkey ||
                        ^^^^
    We return here.
    
       508              (hfunc != ETH_RSS_HASH_NO_CHANGE && hfunc !=
    ETH_RSS_HASH_TOP))
       509                  return -EOPNOTSUPP;
       510
       511          rss->enable = true;
       512          if (indir) {
       513                  for (idx = 0; idx < rss->rss_size; idx++)
       514                          rss->ind_tbl[idx] = indir[idx];
       515          }
       516
       517          if (hkey) {
                        ^^^^
    So this is dead code.
    
       518                  memcpy(rss->key, hkey, RSS_HASH_KEY_SIZE *
    sizeof(u64));
       519                  nicvf_set_rss_key(nic);
       520          }
       521
       522          nicvf_config_rss(nic);
       523          return 0;
       524  }
    
    regards,
    dan carpenter
    Reported-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
    Signed-off-by: default avatarAleksey Makarov <aleksey.makarov@caviumnetworks.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    89987844
nicvf_ethtool.c 15.9 KB