• Geert Uytterhoeven's avatar
    USB: serial: f81534: detect errors from f81534_logic_to_phy_port() · 42715763
    Geert Uytterhoeven authored
    With gcc 4.1.2:
    
        drivers/usb/serial/f81534.c: In function ‘f81534_port_probe’:
        drivers/usb/serial/f81534.c:1250: warning: comparison is always false due to limited range of data type
    
    f81534_logic_to_phy_port() may return a negative error value, which is
    ignored by assigning it to u8 f81534_port_private.phy_num.
    
    Use an intermediate variable of type int to fix this.
    While at it, forward the actual error code instead of converting it to
    -ENODEV, and drop the useless check for F81534_NUM_PORT, as the callee
    always returns a valid port number in case of success.
    
    Fixes: 0c9bd600 ("USB: serial: add Fintek F81532/534 driver")
    Signed-off-by: default avatarGeert Uytterhoeven <geert@linux-m68k.org>
    Signed-off-by: default avatarJohan Hovold <johan@kernel.org>
    42715763
f81534.c 34.3 KB