• Keno Fischer's avatar
    arm64: Fix PTRACE_SYSEMU semantics · 1cf6022b
    Keno Fischer authored
    Quoth the man page:
    ```
           If the tracee was restarted by PTRACE_SYSCALL or PTRACE_SYSEMU, the
           tracee enters syscall-enter-stop just prior to entering any system
           call (which will not be executed if the restart was using
           PTRACE_SYSEMU, regardless of any change made to registers at this
           point or how the tracee is restarted after this stop).
    ```
    
    The parenthetical comment is currently true on x86 and powerpc,
    but not currently true on arm64. arm64 re-checks the _TIF_SYSCALL_EMU
    flag after the syscall entry ptrace stop. However, at this point,
    it reflects which method was used to re-start the syscall
    at the entry stop, rather than the method that was used to reach it.
    Fix that by recording the original flag before performing the ptrace
    stop, bringing the behavior in line with documentation and x86/powerpc.
    
    Fixes: f086f674 ("arm64: ptrace: add support for syscall emulation")
    Cc: <stable@vger.kernel.org> # 5.3.x-
    Signed-off-by: default avatarKeno Fischer <keno@juliacomputing.com>
    Acked-by: default avatarWill Deacon <will@kernel.org>
    Tested-by: default avatarSudeep Holla <sudeep.holla@arm.com>
    Tested-by: default avatarBin Lu <Bin.Lu@arm.com>
    [catalin.marinas@arm.com: moved 'flags' bit masking]
    [catalin.marinas@arm.com: changed 'flags' type to unsigned long]
    Signed-off-by: default avatarCatalin Marinas <catalin.marinas@arm.com>
    1cf6022b
ptrace.c 46.4 KB