• Daniel Vetter's avatar
    vga_switcheroo: Depend upon fbcon being built-in, if enabled · 6116b892
    Daniel Vetter authored
    Fixes linking fail when fbcon/fbdev is modular and vgaswitcheroo is
    enabled:
    
    x86_64-linux-gnu-ld: drivers/gpu/vga/vga_switcheroo.o: in function `vga_switchto_stage2':
    vga_switcheroo.c:(.text+0x997): undefined reference to `fbcon_remap_all'
    
    Unfortunately this means that in a default allmodconfig we will disable vgaswitcheroo.
    
    v2: I first tried to fix this with an EXPORT_SYMBOL, but vga_switcheroo is
    never a module, so this doesn't work.
    Reported-by: default avatarStephen Rothwell <sfr@canb.auug.org.au>
    Reported-by: default avatarkbuild test robot <lkp@intel.com>
    Fixes: 1cd51b5d ("vgaswitcheroo: call fbcon_remap_all directly")
    Signed-off-by: default avatarDaniel Vetter <daniel.vetter@intel.com>
    Cc: Stephen Rothwell <sfr@canb.auug.org.au>
    Cc: Lukas Wunner <lukas@wunner.de>
    Cc: Daniel Vetter <daniel.vetter@intel.com>
    Cc: Sam Ravnborg <sam@ravnborg.org>
    Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
    Cc: David Airlie <airlied@linux.ie>
    Cc: Daniel Vetter <daniel@ffwll.ch>
    Cc: Maxime Ripard <maxime.ripard@bootlin.com>
    Cc: Sean Paul <sean@poorly.run>
    Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
    Cc: Hans de Goede <hdegoede@redhat.com>
    Cc: Yisheng Xie <ysxie@foxmail.com>
    Cc: linux-fbdev@vger.kernel.org
    Cc: Daniel Thompson <daniel.thompson@linaro.org>
    Cc: Lee Jones <lee.jones@linaro.org>
    Cc: dri-devel@lists.freedesktop.org
    Cc: linux-fbdev@vger.kernel.org
    Signed-off-by: default avatarMaarten Lankhorst <maarten.lankhorst@linux.intel.com>
    Link: https://patchwork.freedesktop.org/patch/msgid/20190624092153.23375-1-daniel.vetter@ffwll.ch
    6116b892
Kconfig 1.13 KB