• Keith Owens's avatar
    [PATCH] x86_64: Standardize i386/x86_64 handling of NMI_VECTOR · 45486f81
    Keith Owens authored
    x86_64 and i386 behave inconsistently when sending an IPI on vector 2
    (NMI_VECTOR).  Make both behave the same, so IPI 2 is sent as NMI.
    
    The crash code was abusing send_IPI_allbutself() by passing a code
    instead of a vector, it only worked because crash knew about the
    internal code of send_IPI_allbutself().  Change crash to use NMI_VECTOR
    instead, and remove the comment about how crash was abusing the function.
    
    This patch is a pre-requisite for fixing the problem where sending an
    IPI as NMI would reboot some Dell Xeon systems.  I cannot fix that
    problem while crash continus to abuse send_IPI_allbutself().
    
    It also removes the inconsistency between i386 and x86_64 for
    NMI_VECTOR.  That will simplify all the RAS code that needs to bring
    all the cpus to a clean stop, even when one or more cpus are spinning
    disabled.
    Signed-off-by: default avatarKeith Owens <kaos@sgi.com>
    Signed-off-by: default avatarAndi Kleen <ak@suse.de>
    Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
    45486f81
crash.c 4.07 KB