• Srivatsa S. Bhat's avatar
    x86, kvm: Fix CPU hotplug callback registration · 460dd42e
    Srivatsa S. Bhat authored
    Subsystems that want to register CPU hotplug callbacks, as well as perform
    initialization for the CPUs that are already online, often do it as shown
    below:
    
    	get_online_cpus();
    
    	for_each_online_cpu(cpu)
    		init_cpu(cpu);
    
    	register_cpu_notifier(&foobar_cpu_notifier);
    
    	put_online_cpus();
    
    This is wrong, since it is prone to ABBA deadlocks involving the
    cpu_add_remove_lock and the cpu_hotplug.lock (when running concurrently
    with CPU hotplug operations).
    
    Instead, the correct and race-free way of performing the callback
    registration is:
    
    	cpu_notifier_register_begin();
    
    	for_each_online_cpu(cpu)
    		init_cpu(cpu);
    
    	/* Note the use of the double underscored version of the API */
    	__register_cpu_notifier(&foobar_cpu_notifier);
    
    	cpu_notifier_register_done();
    
    Fix the kvm code in x86 by using this latter form of callback registration.
    
    Cc: Gleb Natapov <gleb@kernel.org>
    Cc: Thomas Gleixner <tglx@linutronix.de>
    Cc: Ingo Molnar <mingo@kernel.org>
    Cc: "H. Peter Anvin" <hpa@zytor.com>
    Acked-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
    Signed-off-by: default avatarSrivatsa S. Bhat <srivatsa.bhat@linux.vnet.ibm.com>
    Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
    460dd42e
x86.c 187 KB