• Denys Vlasenko's avatar
    x86/asm/entry/64: Fix comment about SYSENTER MSRs · 487d1edb
    Denys Vlasenko authored
    The comment is ancient, it dates to the time when only AMD's
    x86_64 implementation existed. AMD wasn't (and still isn't)
    supporting SYSENTER, so these writes were "just in case" back
    then.
    
    This has changed: Intel's x86_64 appeared, and Intel does
    support SYSENTER in long mode. "Some future 64-bit CPU" is here
    already.
    
    The code may appear "buggy" for AMD as it stands, since
    MSR_IA32_SYSENTER_EIP is only 32-bit for AMD CPUs. Writing a
    kernel function's address to it would drop high bits. Subsequent
    use of this MSR for branch via SYSENTER seem to allow user to
    transition to CPL0 while executing his code. Scary, eh?
    
    Explain why that is not a bug: because SYSENTER insn would not
    work on AMD CPU.
    Signed-off-by: default avatarDenys Vlasenko <dvlasenk@redhat.com>
    Cc: Alexei Starovoitov <ast@plumgrid.com>
    Cc: Andy Lutomirski <luto@amacapital.net>
    Cc: Borislav Petkov <bp@alien8.de>
    Cc: Frederic Weisbecker <fweisbec@gmail.com>
    Cc: H. Peter Anvin <hpa@zytor.com>
    Cc: Kees Cook <keescook@chromium.org>
    Cc: Linus Torvalds <torvalds@linux-foundation.org>
    Cc: Oleg Nesterov <oleg@redhat.com>
    Cc: Steven Rostedt <rostedt@goodmis.org>
    Cc: Will Drewry <wad@chromium.org>
    Link: http://lkml.kernel.org/r/1427453956-21931-1-git-send-email-dvlasenk@redhat.comSigned-off-by: default avatarIngo Molnar <mingo@kernel.org>
    487d1edb
common.c 34.9 KB