• Daniel J Blueman's avatar
    drm/i915: Fix gen6 (SNB) missed BLT ring interrupts. · 498e720b
    Daniel J Blueman authored
    The failure appeared in dmesg as:
    
    [drm:i915_hangcheck_ring_idle] *ERROR* Hangcheck timer elapsed... blt
    ring idle [waiting on 35064155, at 35064155], missed IRQ?
    
    This works around that problem on by making the blitter command
    streamer write interrupt state to the Hardware Status Page when a
    MI_USER_INTERRUPT command is decoded, which appears to force the seqno
    out to memory before the interrupt happens.
    
    v1->v2: Moved to prior interrupt handler installation and RMW flags as
    per feedback.
    v2->v3: Removed RMW of flags (by anholt)
    
    Cc: stable@kernel.org
    Signed-off-by: default avatarDaniel J Blueman <daniel.blueman@gmail.com>
    Signed-off-by: default avatarEric Anholt <eric@anholt.net>
    Tested-by: Chris Wilson <chris@chris-wilson.co.uk> [v1]
    Tested-by: Eric Anholt <eric@anholt.net> [v1,v3]
    	   (incidence of the bug with a testcase went from avg 2/1000 to
    	   0/12651 in the latest test run (plus more for v1))
    Tested-by: Kenneth Graunke <kenneth@whitecape.org> [v1]
    Tested-by: Robert Hooker <robert.hooker@canonical.com> [v1]
    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=33394Signed-off-by: default avatarDave Airlie <airlied@redhat.com>
    498e720b
i915_irq.c 55.3 KB