• Rodrigo Vivi's avatar
    drm/i915/skl: Fix has_ipc on skl and document WaDisableIPC. · 4d6ef0da
    Rodrigo Vivi authored
    According to Spec for SKL+: "Isochronous Priority Control.
    If enabled, Display sends demoted requests once the transition
    watermark is reached. If transition watermark is not enabled,
    Display sends demoted requests when the display buffer is full."
    
    The commit 'e57f1c02 ("drm/i915/gen9+: Add has_ipc flag in
    device info structure")' introduced that as gen9+ but missing many
    SKL Skus.
    
    I believe the reason for that is Spec also mentions workarounds for
    SKL-ALL: "IPC (Isoch Priority Control) may cause underflows
    WA: Do not enable IPC in register ARB_CTL2"
    
    It seems lame to add the feature and forever disable it,
    but it will avoid a mistake of enabling it when we are reorganizing
    the feature definitions on i915_pci.c later.
    
    It will also allow us to probably extend that workaround for
    other platforms.
    
    Cc: Mahesh Kumar <mahesh1.kumar@intel.com>
    Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
    Cc: Chris Wilson <chris@chris-wilson.co.uk>
    Signed-off-by: default avatarRodrigo Vivi <rodrigo.vivi@intel.com>
    Reviewed-by: default avatarMahesh Kumar <mahesh1.kumar@intel.com>
    Link: https://patchwork.freedesktop.org/patch/msgid/20171003063652.17248-1-rodrigo.vivi@intel.com
    4d6ef0da
i915_pci.c 18.8 KB