• Petr Machata's avatar
    mlxsw: spectrum: Prevent duplicate mirrors · 663f1b26
    Petr Machata authored
    The Spectrum ASIC doesn't support mirroring more than once from a single
    binding point (which is a port-direction pair). Therefore detect that a
    second binding of a given binding point is attempted.
    
    To that end, extend struct mlxsw_sp_span_inspected_port to track whether
    a given binding point is bound or not. Extend
    mlxsw_sp_span_entry_port_find() to look for ports based on the full
    unique key: port number, direction, and boundness.
    
    Besides fixing the overt bug where configured mirrors are not offloaded,
    this also fixes a more subtle bug: mlxsw_sp_span_inspected_port_del()
    just defers to mlxsw_sp_span_entry_bound_port_find(), and that used to
    find the first port with the right number (disregarding the type). Thus
    by adding and removing egress and ingress mirrors in the right order,
    one could trick the system into believing it has no egress mirrors when
    in fact it did have some. That then caused that
    mlxsw_sp_span_port_mtu_update() didn't update mirroring buffer when MTU
    was changed.
    
    Fixes: 763b4b70 ("mlxsw: spectrum: Add support in matchall mirror TC offloading")
    Signed-off-by: default avatarPetr Machata <petrm@mellanox.com>
    Signed-off-by: default avatarIdo Schimmel <idosch@mellanox.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    663f1b26
spectrum.h 23 KB