• Horia Geantă's avatar
    crypto: caam/qi - fix error handling in ERN handler · 51fab3d7
    Horia Geantă authored
    ERN handler calls the caam/qi frontend "done" callback with a status
    of -EIO. This is incorrect, since the callback expects a status value
    meaningful for the crypto engine - hence the cryptic messages
    like the one below:
    platform caam_qi: 15: unknown error source
    
    Fix this by providing the callback with:
    -the status returned by the crypto engine (fd[status]) in case
    it contains an error, OR
    -a QI "No error" code otherwise; this will trigger the message:
    platform caam_qi: 50000000: Queue Manager Interface: No error
    which is fine, since QMan driver provides details about the cause of
    failure
    
    Cc: <stable@vger.kernel.org> # v5.1+
    Fixes: 67c2315d ("crypto: caam - add Queue Interface (QI) backend support")
    Signed-off-by: default avatarHoria Geantă <horia.geanta@nxp.com>
    Reviewed-by: default avatarIuliana Prodan <iuliana.prodan@nxp.com>
    Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
    51fab3d7
error.c 12.8 KB