• Vladimir Oltean's avatar
    net: dsa: sja1105: Really make the PTP command read-write · 5a47f588
    Vladimir Oltean authored
    When activating tc-taprio offload on the switch ports, the TAS state
    machine will try to check whether it is running or not, but will find
    both the STARTED and STOPPED bits as false in the
    sja1105_tas_check_running function. So the function will return -EINVAL
    (an abnormal situation) and the kernel will keep printing this from the
    TAS FSM workqueue:
    
    [   37.691971] sja1105 spi0.1: An operation returned -22
    
    The reason is that the underlying function that gets called,
    sja1105_ptp_commit, does not actually do a SPI_READ, but a SPI_WRITE. So
    the command buffer remains initialized with zeroes instead of retrieving
    the hardware state. Fix that.
    
    Fixes: 41603d78 ("net: dsa: sja1105: Make the PTP command read-write")
    Signed-off-by: default avatarVladimir Oltean <olteanv@gmail.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    5a47f588
sja1105_ptp.c 18.5 KB