• Andrey Borzenkov's avatar
    orinoco: fix GFP_KERNEL in orinoco_set_key with interrupts disabled · 5b069150
    Andrey Borzenkov authored
    orinoco_set_key is called from two places both with interrupts disabled
    (under orinoco_lock). Use GFP_ATOMIC instead of GFP_KERNEL. Fixes following
    warning:
    
    [   77.254109] WARNING: at /home/bor/src/linux-git/kernel/lockdep.c:2465 lockdep_trace_alloc+0x9a/0xa0()
    [   77.254109] Hardware name: PORTEGE 4000
    [   77.254109] Modules linked in: af_packet irnet ppp_generic slhc ircomm_tty ircomm binfmt_misc dm_mirror dm_region_hash dm_log dm_round_robin dm_multipath dm_mod loop nvram toshiba cryptomgr aead pcompress crypto_blkcipher michael_mic crypto_hash crypto_algapi orinoco_cs orinoco cfg80211 smsc_ircc2 pcmcia irda toshiba_acpi yenta_socket video i2c_ali1535 backlight rsrc_nonstatic ali_agp pcmcia_core psmouse output crc_ccitt i2c_core alim1535_wdt rfkill sg evdev ohci_hcd agpgart usbcore pata_ali libata reiserfs [last unloaded: scsi_wait_scan]
    [   77.254109] Pid: 2296, comm: wpa_supplicant Not tainted 2.6.32-1avb #1
    [   77.254109] Call Trace:
    [   77.254109]  [<c011f0ad>] warn_slowpath_common+0x6d/0xa0
    [   77.254109]  [<c014206a>] ? lockdep_trace_alloc+0x9a/0xa0
    [   77.254109]  [<c014206a>] ? lockdep_trace_alloc+0x9a/0xa0
    [   77.254109]  [<c011f0f5>] warn_slowpath_null+0x15/0x20
    [   77.254109]  [<c014206a>] lockdep_trace_alloc+0x9a/0xa0
    [   77.254109]  [<c018d296>] __kmalloc+0x36/0x130
    [   77.254109]  [<dffcb6a8>] ? orinoco_set_key+0x48/0x1c0 [orinoco]
    [   77.254109]  [<dffcb6a8>] orinoco_set_key+0x48/0x1c0 [orinoco]
    [   77.254109]  [<dffcb9fc>] orinoco_ioctl_set_encodeext+0x1dc/0x2d0 [orinoco]
    [   77.254109]  [<c035b117>] ioctl_standard_call+0x207/0x3b0
    [   77.254109]  [<dffcb820>] ? orinoco_ioctl_set_encodeext+0x0/0x2d0 [orinoco]
    [   77.254109]  [<c0307f1f>] ? rtnl_lock+0xf/0x20
    [   77.254109]  [<c0307f1f>] ? rtnl_lock+0xf/0x20
    [   77.254109]  [<c02fb115>] ? __dev_get_by_name+0x85/0xb0
    [   77.254109]  [<c035b616>] wext_handle_ioctl+0x176/0x200
    [   77.254109]  [<dffcb820>] ? orinoco_ioctl_set_encodeext+0x0/0x2d0 [orinoco]
    [   77.254109]  [<c030020f>] dev_ioctl+0x6af/0x730
    [   77.254109]  [<c02eec65>] ? move_addr_to_kernel+0x55/0x60
    [   77.254109]  [<c02eed59>] ? sys_sendto+0xe9/0x130
    [   77.254109]  [<c02ed77e>] sock_ioctl+0x7e/0x250
    [   77.254109]  [<c02ed700>] ? sock_ioctl+0x0/0x250
    [   77.254109]  [<c019cf4c>] vfs_ioctl+0x1c/0x70
    [   77.254109]  [<c019d1fa>] do_vfs_ioctl+0x6a/0x590
    [   77.254109]  [<c0178e50>] ? might_fault+0x90/0xa0
    [   77.254109]  [<c0178e0a>] ? might_fault+0x4a/0xa0
    [   77.254109]  [<c02ef90e>] ? sys_socketcall+0x17e/0x280
    [   77.254109]  [<c019d759>] sys_ioctl+0x39/0x60
    [   77.254109]  [<c0102e3b>] sysenter_do_call+0x12/0x32
    [   77.254109] ---[ end trace 95ef563548d21efd ]---
    Signed-off-by: default avatarAndrey Borzenkov <arvidjaar@mail.ru>
    Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
    5b069150
wext.c 37.2 KB