• Maxime Ripard's avatar
    ASoC: sun4i-i2s: Change SR and WSS computation · 619c15f7
    Maxime Ripard authored
    The current computation for the SR (sample resolution) and the WSS (word
    slot size) register parameters is based on a switch returning the matching
    parameters for a given params width.
    
    Later SoCs (A83t, H3, A64) changed that calculation, which was loosely the
    same with an offset. Therefore, an offset was added to adjust those
    parameters.
    
    However, the calculation is a bit less trivial than initially thought.
    Indeed, while we assumed that SR and WSS were always the same, on older
    SoCs, SR will max at 24 (since those SoCs do not support 32 bits formats),
    but the word size can be 32.
    
    Newer SoCs can also support a much larger range (8 bits to 32 bits, by
    increments of 4) of size than the older SoCs could.
    
    Finally, the A64 and A83t were never adjusted to have that offset in the
    first place, and were therefore broken from that point of view.
    
    In order to fix all those issues, let's introduce two functions, get_wss
    and get_sr, with their respective implementations for all the SoCs
    supported so far.
    
    Fixes: 21faaea1 ("ASoC: sun4i-i2s: Add support for A83T")
    Fixes: 66ecce33 ("ASoC: sun4i-i2s: Add compatibility with A64 codec I2S")
    Signed-off-by: default avatarMaxime Ripard <maxime.ripard@bootlin.com>
    Signed-off-by: default avatarMark Brown <broonie@kernel.org>
    619c15f7
sun4i-i2s.c 34.5 KB