• Chen Gang's avatar
    arch/microblaze/include/asm/uaccess.h: Use pr_devel() instead of pr_debug() · de295cf0
    Chen Gang authored
    When DYNAMIC_DEBUG enabled, pr_debug() depends on KBUILD_MODNAME which
    also depends on the modules number in Makefile. The related information
    in "scripts/Makefile.lib" line 94:
    
      # $(modname_flags) #defines KBUILD_MODNAME as the name of the module it will
      # end up in (or would, if it gets compiled in)
      # Note: Files that end up in two or more modules are compiled without the
      #       KBUILD_MODNAME definition. The reason is that any made-up name would
      #       differ in different configs.
    
    For this case, 'radio-si470x-i2c.o' and 'radio-si470x-common.o' are in
    one line, so cause compiling issue. And 'uaccess.h' is a common shared
    header (not specially for drivers), so use pr_devel() instead of is OK.
    
    The related error with allmodconfig:
    
        CC [M]  drivers/media/radio/si470x/radio-si470x-i2c.o
        CC [M]  drivers/media/radio/si470x/radio-si470x-common.o
      In file included from include/linux/printk.h:257:0,
                       from include/linux/kernel.h:13,
                       from drivers/media/radio/si470x/radio-si470x.h:29,
                       from drivers/media/radio/si470x/radio-si470x-common.c:115:
      ./arch/microblaze/include/asm/uaccess.h: In function 'access_ok':
      include/linux/dynamic_debug.h:66:14: error: 'KBUILD_MODNAME' undeclared (first use in this function)
         .modname = KBUILD_MODNAME,   \
                    ^
      include/linux/dynamic_debug.h:76:2: note: in expansion of macro 'DEFINE_DYNAMIC_DEBUG_METADATA'
        DEFINE_DYNAMIC_DEBUG_METADATA(descriptor, fmt);  \
        ^
      include/linux/printk.h:263:2: note: in expansion of macro 'dynamic_pr_debug'
        dynamic_pr_debug(fmt, ##__VA_ARGS__)
        ^
      ./arch/microblaze/include/asm/uaccess.h:101:3: note: in expansion of macro 'pr_debug'
         pr_debug("ACCESS fail: %s at 0x%08x (size 0x%x), seg 0x%08x\n",
         ^
    Signed-off-by: default avatarChen Gang <gang.chen.5i5j@gmail.com>
    Signed-off-by: default avatarMichal Simek <michal.simek@xilinx.com>
    de295cf0
uaccess.h 11.3 KB