• Chen-Yu Tsai's avatar
    Bluetooth: hci_bcm: Fix empty regulator supplies for Intel Macs · 62611abc
    Chen-Yu Tsai authored
    The code path for Macs goes through bcm_apple_get_resources(), which
    skips over the code that sets up the regulator supplies. As a result,
    the call to regulator_bulk_enable() / regulator_bulk_disable() results
    in a NULL pointer dereference.
    
    This was reported on the kernel.org Bugzilla, bug 202963.
    
    Unbreak Broadcom Bluetooth support on Intel Macs by checking if the
    supplies were set up before enabling or disabling them.
    
    The same does not need to be done for the clocks, as the common clock
    framework API checks for NULL pointers.
    
    Fixes: 75d11676 ("Bluetooth: hci_bcm: Add support for regulator supplies")
    Cc: <stable@vger.kernel.org> # 5.0.x
    Signed-off-by: default avatarChen-Yu Tsai <wens@csie.org>
    Tested-by: default avatarImre Kaloz <kaloz@openwrt.org>
    Signed-off-by: default avatarMarcel Holtmann <marcel@holtmann.org>
    62611abc
hci_bcm.c 33.3 KB