• Paulo Zanoni's avatar
    drm/i915: completely rewrite the Haswell PLL handling code · 6441ab5f
    Paulo Zanoni authored
    Problems with the previous code:
      - HDMI just uses WRPLL1 for everything, so dual head cases might not
        work sometimes.
      - At encoder->mode_set we just write the PLL register without doing
        any kind of check (e.g., check if the PLL is already being used).
      - There is no way to fail and return error codes at
        encoder->mode_set.
      - We write to PORT_CLK_SEL at mode_set and we never disable it.
      - Machines hang due to wrong clock enable/disable sequence.
    
    So here we rewrite the code, making it a little more like the
    pre-Haswell PLL mode set code:
      - Check PLL availability at ironlake_crtc_mode_set.
      - Try to use both WRPLLs.
      - Check if PLLs are used before actually trying to use them, and
        properly fail with error messages.
      - Enable/disable PORT_CLK_SEL at the right place.
      - Add some WARNs to check for bugs.
    
    The next improvement will be to try to reuse PLLs if the timings
    match, but this is content for another patch and it's already
    documented with a TODO comment.
    Signed-off-by: default avatarPaulo Zanoni <paulo.r.zanoni@intel.com>
    Reviewed-by: default avatarDamien Lespiau <damien.lespiau@intel.com>
    Signed-off-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
    6441ab5f
intel_display.c 234 KB