• Andrew Morton's avatar
    [PATCH] Fix race condition between aio_complete and · 679c40a8
    Andrew Morton authored
    From: "Chen, Kenneth W" <kenneth.w.chen@intel.com>
    
    We hit a memory ordering race condition on AIO ring buffer tail pointer
    between function aio_complete() and aio_read_evt().
    
    What happens is that on an architecture that has a relaxed memory ordering
    model like IPF(ia64), explicit memory barrier is required in a SMP
    execution environment.  Considering the following case:
    
    1 CPU is executing a tight loop of aio_read_evt.  It is pulling event off
    the ring buffer.  During that loop, another CPU is executing aio_complete()
    where it is putting event into the ring buffer and then update the tail
    pointer.  However, due to relaxed memory ordering model, the tail pointer
    can be visible before the actual event is being updated.  So the other CPU
    sees the updated tail pointer but picks up a staled event data.
    
    A memory barrier is required in this case between the event data and tail
    pointer update.  Same is true for the head pointer but the window of the
    race condition is nil.  For function correctness, it is fixed here as well.
    
    By the way, this bug is fixed in the major distributor's kernel on 2.4.x
    kernel series for a while, but somehow hasn't been propagated to 2.5 kernel
    yet.
    679c40a8
aio.c 30.8 KB