• Neil Horman's avatar
    vmxnet3: set carrier state properly on probe · 6cdd20c3
    Neil Horman authored
    vmxnet3 fails to set netif_carrier_off on probe, meaning that when an interface
    is opened the __LINK_STATE_NOCARRIER bit is already cleared, and so
    /sys/class/net/<ifname>/operstate remains in the unknown state.  Correct this by
    setting netif_carrier_off on probe, like other drivers do.
    
    Also, while we're at it, lets remove the netif_carrier_ok checks from the
    link_state_update function, as that check is atomically contained within the
    netif_carrier_[on|off] functions anyway
    
    Tested successfully by myself
    Signed-off-by: default avatarNeil Horman <nhorman@tuxdriver.com>
    CC: "David S. Miller" <davem@davemloft.net>
    CC: "VMware, Inc." <pv-drivers@vmware.com>
    CC: Ben Hutchings <bhutchings@solarflare.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    6cdd20c3
vmxnet3_drv.c 87.1 KB