• Alexander Graf's avatar
    igb: Indicate failure on vf reset for empty mac address · 6ddbc4cf
    Alexander Graf authored
    Commit 5ac6f91d changed the igb driver to expose a zero (empty) mac
    address to the VF on reset rather than a random one.
    
    However, that behavioral change also requires igbvf driver changes
    which can be hard especially when we want to talk to proprietary
    guest OSs.
    
    Looking at the code previous to the commit in Linux that made igbvf
    work with empty mac addresses (8d56b6d5), we can see that on reset
    failure the driver will try to generate a new mac address with both
    the old and the new code.
    
    Furthermore, ixgbe does send reset failure when it detects an empty
    mac address (35055928).
    
    So I think it's safe to make igb behave the same. With this patch I
    can successfully run a Windows 8.1 guest with an empty mac address
    and an assigned igbvf device that has no mac address set by the host.
    
    If anyone is aware of a guest driver that chokes on NACK returns of
    VF RESET commands, please speak up.
    Signed-off-by: default avatarAlexander Graf <agraf@suse.de>
    Tested-by: default avatarAaron Brown <aaron.f.brown@intel.com>
    Signed-off-by: default avatarJeff Kirsher <jeffrey.t.kirsher@intel.com>
    6ddbc4cf
igb_main.c 217 KB