• Chris Leech's avatar
    scsi: libiscsi: add lock around task lists to fix list corruption regression · 6f8830f5
    Chris Leech authored
    There's a rather long standing regression from the commit "libiscsi:
    Reduce locking contention in fast path"
    
    Depending on iSCSI target behavior, it's possible to hit the case in
    iscsi_complete_task where the task is still on a pending list
    (!list_empty(&task->running)).  When that happens the task is removed
    from the list while holding the session back_lock, but other task list
    modification occur under the frwd_lock.  That leads to linked list
    corruption and eventually a panicked system.
    
    Rather than back out the session lock split entirely, in order to try
    and keep some of the performance gains this patch adds another lock to
    maintain the task lists integrity.
    
    Major enterprise supported kernels have been backing out the lock split
    for while now, thanks to the efforts at IBM where a lab setup has the
    most reliable reproducer I've seen on this issue.  This patch has been
    tested there successfully.
    Signed-off-by: default avatarChris Leech <cleech@redhat.com>
    Fixes: 659743b0 ("[SCSI] libiscsi: Reduce locking contention in fast path")
    Reported-by: default avatarPrashantha Subbarao <psubbara@us.ibm.com>
    Reviewed-by: default avatarGuilherme G. Piccoli <gpiccoli@linux.vnet.ibm.com>
    Cc: <stable@vger.kernel.org> # v3.15+
    Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
    6f8830f5
libiscsi.h 14.3 KB