• Ben Widawsky's avatar
    drm/i915: Fix RC6VIDS encode/decode · 7083e050
    Ben Widawsky authored
    The RC6 VIDS has a linear ramp starting at 250mv, which means any values
    below 250 are invalid. The old buggy macros tried to adjust for this to
    be more flexible, but there is no need. As Dan pointed out the ENCODE
    only ever has one value. The only invalid value for decode is an input
    of 0 which means something is really wonky, and the cases where DECODE
    are used either don't matter (debug values), or would be implicitly
    correct (the check for less than 450).
    
    This patch makes simpler, easier to read macros which are actually
    correct. Maybe this patch can actually fix some bugs now.
    
    Thanks to Dan for catching this. /me hides
    
    Cc: stable@kernel.org
    Reported-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
    Signed-off-by: default avatarBen Widawsky <ben@bwidawsk.net>
    Signed-off-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
    7083e050
i915_reg.h 172 KB