• Lorenzo Pieralisi's avatar
    ACPI: Drop misplaced acpi_dma_deconfigure() call from acpi_bind_one() · 709f94ff
    Lorenzo Pieralisi authored
    The acpi_bind_one() error return path can be hit either on physical node
    allocation failure or if the device being configured is already
    associated with an ACPI node and its ACPI companion does not match the
    one acpi_bind_one() is setting it up with. In both cases the error
    return path is executed before DMA is configured for a device therefore
    there is no need to call acpi_dma_deconfigure() on the function error
    return path.
    
    Furthermore, if acpi_bind_one() does configure DMA for a device (ie it
    successfully executes acpi_dma_configure()) acpi_bind_one() always
    completes execution successfully hence there is no need to add an exit
    path to deconfigure the DMA set-up (ie by calling acpi_dma_deconfigure()).
    
    Remove the misplaced acpi_dma_deconfigure() in acpi_bind_one() to
    reinstate its correct error return path behaviour.
    
    Fixes: d760a1ba (ACPI: Implement acpi_dma_configure)
    Signed-off-by: default avatarLorenzo Pieralisi <lorenzo.pieralisi@arm.com>
    Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
    709f94ff
glue.c 8.58 KB