• Michael S. Tsirkin's avatar
    virtio-pci: fix use after free · 72103bd1
    Michael S. Tsirkin authored
    Commit 31a3ddda introduced
    a use after free in virtio-pci. The main issue is
    that the release method signals removal of the virtio device,
    while remove signals removal of the pci device.
    
    For example, on driver removal or hot-unplug,
    virtio_pci_release_dev is called before virtio_pci_remove.
    We then might get a crash as virtio_pci_remove tries to use the
    device freed by virtio_pci_release_dev.
    
    We allocate/free all resources together with the
    pci device, so we can leave the release method empty.
    Signed-off-by: default avatarMichael S. Tsirkin <mst@redhat.com>
    Acked-by: default avatarAmit Shah <amit.shah@redhat.com>
    Signed-off-by: default avatarRusty Russell <rusty@rustcorp.com.au>
    Cc: stable@kernel.org
    72103bd1
virtio_pci.c 19.2 KB