• Pierre-Louis Bossart's avatar
    ASoC: soc-dai: revert all changes to DAI startup/shutdown sequence · 5bd70440
    Pierre-Louis Bossart authored
    On Baytrail/Cherrytrail, the Atom/SST driver fails miserably:
    
    [    9.741953] intel_sst_acpi 80860F28:00: FW Version 01.0c.00.01
    [    9.832992] intel_sst_acpi 80860F28:00: FW sent error response 0x40034
    [    9.833019] intel_sst_acpi 80860F28:00: FW alloc failed ret -4
    [    9.833028] intel_sst_acpi 80860F28:00: sst_get_stream returned err -5
    [    9.833033] sst-mfld-platform sst-mfld-platform: ASoC: DAI prepare error: -5
    [    9.833037]  Baytrail Audio Port: ASoC: prepare FE Baytrail Audio Port failed
    [    9.853942] intel_sst_acpi 80860F28:00: FW sent error response 0x40034
    [    9.853974] intel_sst_acpi 80860F28:00: FW alloc failed ret -4
    [    9.853984] intel_sst_acpi 80860F28:00: sst_get_stream returned err -5
    [    9.853990] sst-mfld-platform sst-mfld-platform: ASoC: DAI prepare error: -5
    [    9.853994]  Baytrail Audio Port: ASoC: prepare FE Baytrail Audio Port failed
    
    Commit b56be800 ("ASoC: soc-pcm: call
    snd_soc_dai_startup()/shutdown() once") was the initial problematic
    commit.
    
    Commit 1ba616bd ("ASoC: soc-dai: fix DAI startup/shutdown sequence")
    was an attempt to fix things but it does not work on Baytrail,
    reverting all changes seems necessary for now.
    
    Fixes: 1ba616bd ("ASoC: soc-dai: fix DAI startup/shutdown sequence")
    Signed-off-by: default avatarPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
    Tested-by: default avatarHans de Goede <hdegoede@redhat.com>
    Link: https://lore.kernel.org/r/20200415030437.23803-1-pierre-louis.bossart@linux.intel.comSigned-off-by: default avatarMark Brown <broonie@kernel.org>
    5bd70440
soc-dai.c 10.4 KB