• Jens Axboe's avatar
    io_uring: fix -ENOENT issue with linked timer with short timeout · 76a46e06
    Jens Axboe authored
    If you prep a read (for example) that needs to get punted to async
    context with a timer, if the timeout is sufficiently short, the timer
    request will get completed with -ENOENT as it could not find the read.
    
    The issue is that we prep and start the timer before we start the read.
    Hence the timer can trigger before the read is even started, and the end
    result is then that the timer completes with -ENOENT, while the read
    starts instead of being cancelled by the timer.
    
    Fix this by splitting the linked timer into two parts:
    
    1) Prep and validate the linked timer
    2) Start timer
    
    The read is then started between steps 1 and 2, so we know that the
    timer will always have a consistent view of the read request state.
    Reported-by: default avatarHrvoje Zeba <zeba.hrvoje@gmail.com>
    Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
    76a46e06
io_uring.c 114 KB