• Paolo Valente's avatar
    pkt_sched: sch_qfq: remove a useless invocation of qfq_update_eligible · 76e4cb0d
    Paolo Valente authored
    QFQ+ can select for service only 'eligible' aggregates, i.e.,
    aggregates that would have started to be served also in the emulated
    ideal system.  As a consequence, for QFQ+ to be work conserving, at
    least one of the active aggregates must be eligible when it is time to
    choose the next aggregate to serve.
    
    The set of eligible aggregates is updated through the function
    qfq_update_eligible(), which does guarantee that, after its
    invocation, at least one of the active aggregates is eligible.
    Because of this property, this function is invoked in
    qfq_deactivate_agg() to guarantee that at least one of the active
    aggregates is still eligible after an aggregate has been deactivated.
    In particular, the critical case is when there are other active
    aggregates, but the aggregate being deactivated happens to be the only
    one eligible.
    
    However, this precaution is not needed for QFQ+ to be work conserving,
    because update_eligible() is always invoked also at the beginning of
    qfq_choose_next_agg(). This patch removes the additional invocation of
    update_eligible() in qfq_deactivate_agg().
    Signed-off-by: default avatarPaolo Valente <paolo.valente@unimore.it>
    Reviewed-by: default avatarFabio Checconi <fchecconi@gmail.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    76e4cb0d
sch_qfq.c 41.2 KB