• Eric Sandeen's avatar
    fix inode_table test in ext234_check_descriptors · 780dcdb2
    Eric Sandeen authored
    ext[234]_check_descriptors sanity checks block group descriptor geometry at
    mount time, testing whether the block bitmap, inode bitmap, and inode table
    reside wholly within the blockgroup.  However, the inode table test is off
    by one so that if the last block in the inode table resides on the last
    block of the block group, the test incorrectly fails.  This is because it
    tests the last block as (start + length) rather than (start + length - 1).
    
    This can be seen by trying to mount a filesystem made such as:
    
     mkfs.ext2 -F -b 1024 -m 0 -g 256 -N 3744 fsfile 1024
    
    which yields:
    
     EXT2-fs error (device loop0): ext2_check_descriptors: Inode table for group 0 not in group (block 101)!
     EXT2-fs: group descriptors corrupted!
    
    There is a similar bug in e2fsprogs, patch already sent for that.
    
    (I wonder if inside(), outside(), and/or in_range() should someday be
    used in this and other tests throughout the ext filesystems...)
    Signed-off-by: default avatarEric Sandeen <sandeen@redhat.com>
    Cc: <linux-ext4@vger.kernel.org>
    Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
    Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
    780dcdb2
super.c 35.9 KB