• Waiman Long's avatar
    locking/rwsem: Don't call owner_on_cpu() on read-owner · 78134300
    Waiman Long authored
    For writer, the owner value is cleared on unlock. For reader, it is
    left intact on unlock for providing better debugging aid on crash dump
    and the unlock of one reader may not mean the lock is free.
    
    As a result, the owner_on_cpu() shouldn't be used on read-owner
    as the task pointer value may not be valid and it might have
    been freed. That is the case in rwsem_spin_on_owner(), but not in
    rwsem_can_spin_on_owner(). This can lead to use-after-free error from
    KASAN. For example,
    
      BUG: KASAN: use-after-free in rwsem_down_write_slowpath
      (/home/miguel/kernel/linux/kernel/locking/rwsem.c:669
      /home/miguel/kernel/linux/kernel/locking/rwsem.c:1125)
    
    Fix this by checking for RWSEM_READER_OWNED flag before calling
    owner_on_cpu().
    Reported-by: default avatarLuis Henriques <lhenriques@suse.com>
    Tested-by: default avatarLuis Henriques <lhenriques@suse.com>
    Signed-off-by: default avatarWaiman Long <longman@redhat.com>
    Signed-off-by: default avatarPeter Zijlstra (Intel) <peterz@infradead.org>
    Cc: Borislav Petkov <bp@alien8.de>
    Cc: Davidlohr Bueso <dave@stgolabs.net>
    Cc: H. Peter Anvin <hpa@zytor.com>
    Cc: Jeff Layton <jlayton@kernel.org>
    Cc: Linus Torvalds <torvalds@linux-foundation.org>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: Thomas Gleixner <tglx@linutronix.de>
    Cc: Tim Chen <tim.c.chen@linux.intel.com>
    Cc: Will Deacon <will.deacon@arm.com>
    Cc: huang ying <huang.ying.caritas@gmail.com>
    Fixes: 94a9717b ("locking/rwsem: Make rwsem->owner an atomic_long_t")
    Link: https://lkml.kernel.org/r/81e82d5b-5074-77e8-7204-28479bbe0df0@redhat.comSigned-off-by: default avatarIngo Molnar <mingo@kernel.org>
    78134300
rwsem.c 45.6 KB