• Andrew Morton's avatar
    [PATCH] put_user() warning fix · 7857e0a1
    Andrew Morton authored
    Patch from Russell King <rmk@arm.linux.org.uk>
    
    Have a couple of extra warnings:
    
    fs/binfmt_elf.c: In function `create_elf_tables':
    fs/binfmt_elf.c:239: warning: initialization makes integer from pointer without a cast
    fs/binfmt_elf.c:249: warning: initialization makes integer from pointer without a cast
    
    #ifndef elf_addr_t
    #define elf_addr_t unsigned long
    #endif
    
            elf_addr_t *argv, *envp;
    
            __put_user(NULL, argv);
            __put_user(NULL, envp);
    
    It would therefore appear that x86 __put_user is not properly type-checking
    the arguments to __put_user().
    
    Here's a patch which fixes the warning (but doesn't fix x86's type-check
    challenged __put_user implementation).
    7857e0a1
binfmt_elf.c 36.4 KB