• Eric Dumazet's avatar
    tcp: fix return value for partial writes · 79d8665b
    Eric Dumazet authored
    After my commit, tcp_sendmsg() might restart its loop after
    processing socket backlog.
    
    If sk_err is set, we blindly return an error, even though we
    copied data to user space before.
    
    We should instead return number of bytes that could be copied,
    otherwise user space might resend data and corrupt the stream.
    
    This might happen if another thread is using recvmsg(MSG_ERRQUEUE)
    to process timestamps.
    
    Issue was diagnosed by Soheil and Willem, big kudos to them !
    
    Fixes: d41a69f1 ("tcp: make tcp_sendmsg() aware of socket backlog")
    Signed-off-by: default avatarEric Dumazet <edumazet@google.com>
    Cc: Willem de Bruijn <willemb@google.com>
    Cc: Soheil Hassas Yeganeh <soheil@google.com>
    Cc: Yuchung Cheng <ycheng@google.com>
    Cc: Neal Cardwell <ncardwell@google.com>
    Tested-by: default avatarSoheil Hassas Yeganeh <soheil@google.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    79d8665b
tcp.c 86.2 KB