• Ben Hutchings's avatar
    usbnet: Fix tx_bytes statistic running backward in cdc_ncm · 7a1e890e
    Ben Hutchings authored
    cdc_ncm disagrees with usbnet about how much framing overhead should
    be counted in the tx_bytes statistics, and tries 'fix' this by
    decrementing tx_bytes on the transmit path.  But statistics must never
    be decremented except due to roll-over; this will thoroughly confuse
    user-space.  Also, tx_bytes is only incremented by usbnet in the
    completion path.
    
    Fix this by requiring drivers that set FLAG_MULTI_FRAME to set a
    tx_bytes delta along with the tx_packets count.
    
    Fixes: beeecd42 ("net: cdc_ncm/cdc_mbim: adding NCM protocol statistics")
    Signed-off-by: default avatarBen Hutchings <ben.hutchings@codethink.co.uk>
    Signed-off-by: default avatarBjørn Mork <bjorn@mork.no>
    7a1e890e
asix_common.c 14.8 KB