• Jeff Liu's avatar
    cgroup: warn about mismatching options of a new mount of an existing hierarchy · 2a0ff3fb
    Jeff Liu authored
    With the new __DEVEL__sane_behavior mount option was introduced,
    if the root cgroup is alive with no xattr function, to mount a
    new cgroup with xattr will be rejected in terms of design which
    just fine.  However, if the root cgroup does not mounted with
    __DEVEL__sane_hehavior, to create a new cgroup with xattr option
    will succeed although after that the EA function does not works
    as expected but will get ENOTSUPP for setting up attributes under
    either cgroup. e.g.
    
    setfattr: /cgroup2/test: Operation not supported
    
    Instead of keeping silence in this case, it's better to drop a log
    entry in warning level.  That would be helpful to understand the
    reason behind the scene from the user's perspective, and this is
    essentially an improvement does not break the backward compatibilities.
    
    With this fix, above mount attemption will keep up works as usual but
    the following line cound be found at the system log:
    
    [ ...] cgroup: new mount options do not match the existing superblock
    
    tj: minor formatting / message updates.
    Signed-off-by: default avatarJie Liu <jeff.liu@oracle.com>
    Reported-by: default avatarAlexey Kodanev <alexey.kodanev@oracle.com>
    Signed-off-by: default avatarTejun Heo <tj@kernel.org>
    Cc: stable@vger.kernel.org
    2a0ff3fb
cgroup.c 143 KB