• Jiri Slaby's avatar
    Char: nozomi, remove useless tty_sem · 7fdc2893
    Jiri Slaby authored
    tty_sem used to protect tty open count. This was removed in 33dd474a
    but the lock remained in place.
    
    So remove it completely as it protects nothing now.
    
    Also this solves Mac's problem with inatomic operation called from
    atomic context (ppp):
    BUG: scheduling while atomic: firefox-bin/1992/0x10000800
    Modules linked in: ...
    Pid: 1992, comm: firefox-bin Not tainted 2.6.38 #1
    Call Trace:
    ...
     [] ? mutex_lock+0xe/0x21
     [] ? ntty_write+0x5d/0x192 [nozomi]
     [] ? __mod_timer.clone.30+0xbe/0xcc
     [] ? check_preempt_curr+0x60/0x6d
     [] ? __nf_ct_refresh_acct+0x75/0xbe
     [] ? ppp_async_push+0xa9/0x3bd [ppp_async]
     [] ? ppp_async_send+0x34/0x40 [ppp_async]
     [] ? ppp_push+0x6c/0x4f9 [ppp_generic]
    ...
    Signed-off-by: default avatarJiri Slaby <jslaby@suse.cz>
    Reported-by: default avatarMac <kmac@poczta.fm>
    Tested-by: default avatarGerald Pfeifer <gerald@pfeifer.com>
    Reviewed-by: default avatarJack Stone <jwjstone@fastmail.fm>
    Cc: Alan Cox <alan@linux.intel.com>
    Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
    7fdc2893
nozomi.c 48.4 KB