• Herbert Xu's avatar
    [IPSEC]: Temporarily remove locks around copying of non-atomic fields · 8053fc3d
    Herbert Xu authored
    The change 050f009e
    
    	[IPSEC]: Lock state when copying non-atomic fields to user-space
    
    caused a regression.
    
    Ingo Molnar reports that it causes a potential dead-lock found by the
    lock validator as it tries to take x->lock within xfrm_state_lock while
    numerous other sites take the locks in opposite order.
    
    For 2.6.24, the best fix is to simply remove the added locks as that puts
    us back in the same state as we've been in for years.  For later kernels
    a proper fix would be to reverse the locking order for every xfrm state
    user such that if x->lock is taken together with xfrm_state_lock then
    it is to be taken within it.
    Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
    8053fc3d
xfrm_user.c 54.9 KB