• Paulo Zanoni's avatar
    drm/i915: remove in_dbg_master check from intel_fbc.c · 5205bbe6
    Paulo Zanoni authored
    From our maintainer Daniel Vetter a few days ago:
      "Oh dear this is dead code. kdbg uses the fbcon, which always uses
      untiled, which means fbc will never be enabled. Also we have 0 users
      and 0 test coverage for kdbg on top of i915 (Jesse implemented it
      for fun years back). Imo just remove all this code."
    
    Adding to what Daniel said: for kgdboc's KMS support,
    intel_pipe_set_base_atomic() already manually disables FBC, so we
    won't do the in_dbg_master() check there. This is essentially a revert
    of:
    
    commit c924b934
    Author: Jason Wessel <jason.wessel@windriver.com>
    Date:   Thu Aug 5 09:22:32 2010 -0500
        i915: when kgdb is active display compression should be off
    
    Besides, it is not clear what is the exact problem caused by FBC, and
    why other features such as PSR, DRRS, IPS and RPM are not also
    checking for in_dbg_master(). IMHO we should either remove the code as
    suggested by Daniel or we add some nice comments explaining why is FBC
    so special.
    
    v2: Rebase due to new patch order.
    
    Cc: Jason Wessel <jason.wessel@windriver.com>
    Cc: Jesse Barnes <jbarnes@virtuousgeek.org>
    Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
    Signed-off-by: default avatarPaulo Zanoni <paulo.r.zanoni@intel.com>
    Reviewed-by: default avatarJesse Barnes <jbarnes@virtuousgeek.org>
    Link: http://patchwork.freedesktop.org/patch/msgid/1446664257-32012-13-git-send-email-paulo.r.zanoni@intel.comSigned-off-by: default avatarMaarten Lankhorst <maarten.lankhorst@linux.intel.com>
    5205bbe6
intel_fbc.c 29.6 KB