• Shawn Lin's avatar
    mmc: block: fix ABI regression of mmc_blk_ioctl · 83c742c3
    Shawn Lin authored
    If mmc_blk_ioctl returns -EINVAL, blkdev_ioctl continues to
    work without returning err to user-space. But now we check
    CAP_SYS_RAWIO firstly, so we return -EPERM to blkdev_ioctl,
    which make blkdev_ioctl return -EPERM to user-space directly.
    So this will break all the ioctl with BLKROSET. Now we find
    Android-adb suffer it for the following log:
    
    remount of /system failed;
    couldn't make block device writable: Operation not permitted
    openat(AT_FDCWD, "/dev/block/platform/ff420000.dwmmc/by-name/system", O_RDONLY) = 3
    ioctl(3, BLKROSET, 0)  = -1 EPERM (Operation not permitted)
    
    Fixes: a5f5774c ("mmc: block: Add new ioctl to send multi commands")
    Cc: stable@vger.kernel.org
    Signed-off-by: default avatarShawn Lin <shawn.lin@rock-chips.com>
    Signed-off-by: default avatarUlf Hansson <ulf.hansson@linaro.org>
    83c742c3
block.c 67.5 KB