• Arnd Bergmann's avatar
    backlight: adp88x0: Fix uninitialized variable use · 86c68e2f
    Arnd Bergmann authored
    gcc correctly warns about both the adp8860 and adp8870 backlight
    drivers using an uninitialized variable in their error handling
    path:
    
    drivers/video/backlight/adp8870_bl.c: In function 'adp8870_bl_ambient_light_zone_store':
    drivers/video/backlight/adp8870_bl.c:811:11: warning: 'reg_val' may be used uninitialized in this function
    
    This changes the code to only write back the data if it was
    correctly read to start with.
    
    As a side-note, the drivers are mostly identical, so I think they
    should really be merged into one file to avoid having to fix every
    bug twice.
    Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
    Acked-by: default avatarMichael Hennerich <michael.hennerich@analog.com>
    Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
    86c68e2f
adp8860_bl.c 21.8 KB