• Heiner Kallweit's avatar
    media: rc: nuvoton: remove rudimentary transmit functionality · 87284271
    Heiner Kallweit authored
    Transmit support in this driver was never tested and based on the code
    it can't work. Just one example:
    The buffer provided to nvt_tx_ir holds unsigned int values in
    micro seconds: First value is for a pulse, second for a pause, etc.
    Bytes in this buffer are copied as-is to the chip FIFO what can't work
    as the chip-internal format is totally different. See also conversion
    done in nvt_process_rx_ir_data.
    
    Even if we would try to fix this we have the issue that we can't test
    it. There seems to be no device on the market using IR transmit with
    one of the chips supported by this driver.
    
    To facilitate maintenance of the driver I'd propose to remove the
    rudimentary transmit support.
    Signed-off-by: default avatarHeiner Kallweit <hkallweit1@gmail.com>
    Signed-off-by: default avatarSean Young <sean@mess.org>
    Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
    87284271
nuvoton-cir.h 9.89 KB