• Jeff Layton's avatar
    cifs: fix cifsConvertToUCS() for the mapchars case · 11379b5e
    Jeff Layton authored
    As Metze pointed out, commit 84cdf74e broke mapchars option:
    
        Commit "cifs: fix unaligned accesses in cifsConvertToUCS"
        (84cdf74e) does multiple steps
        in just one commit (moving the function and changing it without
        testing).
    
        put_unaligned_le16(temp, &target[j]); is never called for any
        codepoint the goes via the 'default' switch statement. As a result
        we put just zero (or maybe uninitialized) bytes into the target
        buffer.
    
    His proposed patch looks correct, but doesn't apply to the current head
    of the tree. This patch should also fix it.
    
    Cc: <stable@kernel.org> # .38.x: 581ade4d: cifs: clean up various nits in unicode routines (try #2)
    Reported-by: default avatarStefan Metzmacher <metze@samba.org>
    Signed-off-by: default avatarJeff Layton <jlayton@redhat.com>
    Signed-off-by: default avatarSteve French <sfrench@us.ibm.com>
    11379b5e
cifs_unicode.c 8.77 KB