• Wang Nan's avatar
    perf: Fix building warning on ARM 32 · ac931f87
    Wang Nan authored
    Commit 85c116a6 ("perf callchain: Make get_srcline fall back to sym+offset")
    introduces asprintf() call and matches '%ld' to a u64 argument, which is
    incorrect on ARM:
    
       CC       /home/wn/util/srcline.o
     util/srcline.c: In function 'get_srcline':
     util/srcline.c:297:6: error: format '%ld' expects argument of type 'long int', but argument 4 has type 'u64' [-Werror=format]
     cc1: all warnings being treated as errors
     make[1]: *** [/home/wn/util/srcline.o] Error 1
    
    In addition, all users of get_srcline() use u64 addr, and libbfd
    also use 64 bit bfd_vma as address. This patch also fix
    prototype of get_srcline() and addr2line() to use u64 addr
    instead of unsigned long.
    Signed-off-by: default avatarWang Nan <wangnan0@huawei.com>
    Acked-by: default avatarNamhyung Kim <namhyung@kernel.org>
    Cc: <lizefan@huawei.com>
    Cc: <a.p.zijlstra@chello.nl>
    Cc: <paulus@samba.org>
    Cc: <acme@kernel.org>
    Cc: <ak@linux.intel.com>
    Link: http://lkml.kernel.org/r/1418710746-35943-1-git-send-email-wangnan0@huawei.comSigned-off-by: default avatarIngo Molnar <mingo@kernel.org>
    ac931f87
srcline.c 5.41 KB