• Gustavo A. R. Silva's avatar
    drm/amdkfd/kfd_mqd_manager_v10: Avoid fall-through warning · 12fce1ab
    Gustavo A. R. Silva authored
    In preparation to enabling -Wimplicit-fallthrough, this patch silences
    the following warning:
    
    drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_mqd_manager_v10.c: In function ‘mqd_manager_init_v10’:
    ./include/linux/dynamic_debug.h:122:52: warning: this statement may fall through [-Wimplicit-fallthrough=]
     #define __dynamic_func_call(id, fmt, func, ...) do { \
                                                        ^
    ./include/linux/dynamic_debug.h:143:2: note: in expansion of macro ‘__dynamic_func_call’
      __dynamic_func_call(__UNIQUE_ID(ddebug), fmt, func, ##__VA_ARGS__)
      ^~~~~~~~~~~~~~~~~~~
    ./include/linux/dynamic_debug.h:153:2: note: in expansion of macro ‘_dynamic_func_call’
      _dynamic_func_call(fmt, __dynamic_pr_debug,  \
      ^~~~~~~~~~~~~~~~~~
    ./include/linux/printk.h:336:2: note: in expansion of macro ‘dynamic_pr_debug’
      dynamic_pr_debug(fmt, ##__VA_ARGS__)
      ^~~~~~~~~~~~~~~~
    drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_mqd_manager_v10.c:432:3: note: in expansion of macro ‘pr_debug’
       pr_debug("%s@%i\n", __func__, __LINE__);
       ^~~~~~~~
    drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_mqd_manager_v10.c:433:2: note: here
      case KFD_MQD_TYPE_COMPUTE:
      ^~~~
    
    by removing the call to pr_debug() in KFD_MQD_TYPE_CP:
    
    "The mqd init for CP and COMPUTE will have the same  routine." [1]
    
    This bug was found thanks to the ongoing efforts to enable
    -Wimplicit-fallthrough.
    
    [1] https://lore.kernel.org/lkml/c735a1cc-a545-50fb-44e7-c0ad93ee8ee7@amd.com/Reviewed-by: default avatarAlex Deucher <alexdeucher@gmail.com>
    Signed-off-by: default avatarGustavo A. R. Silva <gustavo@embeddedor.com>
    12fce1ab
kfd_mqd_manager_v10.c 14.4 KB