• Tony Luck's avatar
    x86/mce: Do not use bank 1 for APEI generated error logs · b2de4360
    Tony Luck authored
    BIOS can report a memory error to Linux using ACPI/APEI mechanism. When
    it does this, we create a fictitious machine check error record and
    feed it into the standard mce_log() function. The error record needs a
    machine check bank number, and for some reason we chose "1" for this.
    
    But "1" is a valid bank number, and this causes confusion and heartburn
    among h/w folks who are concerned that a memory error signature was
    somehow logged in bank 1.
    
    Change to use "-1" (field is a "u8" so will typically print as 255).
    This should make it clearer that this error did not originate in a
    machine check bank.
    Signed-off-by: default avatarTony Luck <tony.luck@intel.com>
    Signed-off-by: default avatarBorislav Petkov <bp@suse.de>
    Cc: Andy Lutomirski <luto@amacapital.net>
    Cc: Aristeu Rozanski <arozansk@redhat.com>
    Cc: Borislav Petkov <bp@alien8.de>
    Cc: Brian Gerst <brgerst@gmail.com>
    Cc: Denys Vlasenko <dvlasenk@redhat.com>
    Cc: H. Peter Anvin <hpa@zytor.com>
    Cc: Linus Torvalds <torvalds@linux-foundation.org>
    Cc: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: Thomas Gleixner <tglx@linutronix.de>
    Cc: linux-edac <linux-edac@vger.kernel.org>
    Link: http://lkml.kernel.org/r/b7fffb2b326bc1dd150ffceb9919a803f9496e0e.1464805958.git.tony.luck@intel.comSigned-off-by: default avatarIngo Molnar <mingo@kernel.org>
    b2de4360
mce-apei.c 4.35 KB