• Arnd Bergmann's avatar
    ALSA: als100: fix format string overflow warning · 8a463639
    Arnd Bergmann authored
    The compiler sees that the format string might overflow for the longname:
    
    sound/isa/als100.c: In function 'snd_als100_pnp_detect':
    sound/isa/als100.c:225:27: error: ', dma ' directive writing 6 bytes into a region of size between 0 and 64 [-Werror=format-overflow=]
       sprintf(card->longname, "%s, %s at 0x%lx, irq %d, dma %d",
                               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    sound/isa/als100.c:225:3: note: 'sprintf' output between 24 and 113 bytes into a destination of size 80
       sprintf(card->longname, "%s, %s at 0x%lx, irq %d, dma %d",
    
    Open-coding "shortname" here gets us below the limit, and using
    snprintf() is a good idea too.
    Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
    Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
    8a463639
als100.c 10.4 KB