• Dave Chinner's avatar
    xfs: inode and free block counters need to use __percpu_counter_compare · 8c1903d3
    Dave Chinner authored
    Because the counters use a custom batch size, the comparison
    functions need to be aware of that batch size otherwise the
    comparison does not work correctly. This leads to ASSERT failures
    on generic/027 like this:
    
     XFS: Assertion failed: 0, file: fs/xfs/xfs_mount.c, line: 1099
     ------------[ cut here ]------------
    ....
     Call Trace:
      [<ffffffff81522a39>] xfs_mod_icount+0x99/0xc0
      [<ffffffff815285cb>] xfs_trans_unreserve_and_mod_sb+0x28b/0x5b0
      [<ffffffff8152f941>] xfs_log_commit_cil+0x321/0x580
      [<ffffffff81528e17>] xfs_trans_commit+0xb7/0x260
      [<ffffffff81503d4d>] xfs_bmap_finish+0xcd/0x1b0
      [<ffffffff8151da41>] xfs_inactive_ifree+0x1e1/0x250
      [<ffffffff8151dbe0>] xfs_inactive+0x130/0x200
      [<ffffffff81523a21>] xfs_fs_evict_inode+0x91/0xf0
      [<ffffffff811f3958>] evict+0xb8/0x190
      [<ffffffff811f433b>] iput+0x18b/0x1f0
      [<ffffffff811e8853>] do_unlinkat+0x1f3/0x320
      [<ffffffff811d548a>] ? filp_close+0x5a/0x80
      [<ffffffff811e999b>] SyS_unlinkat+0x1b/0x40
      [<ffffffff81e0892e>] system_call_fastpath+0x12/0x71
    
    This is a regression introduced by commit 501ab323 ("xfs: use generic
    percpu counters for inode counter").
    
    This patch fixes the same problem for both the inode counter and the
    free block counter in the superblocks.
    Signed-off-by: default avatarDave Chinner <dchinner@redhat.com>
    Reviewed-by: default avatarBrian Foster <bfoster@redhat.com>
    Signed-off-by: default avatarDave Chinner <david@fromorbit.com>
    8c1903d3
xfs_mount.c 32 KB